[JENKINS-75278] User pages for users with '\' in the user name fail after upgrading to 2.479.1 by olamy · Pull Request #10344 · jenkinsci/jenkins

olamy · 2025-02-26T00:39:18Z

Signed-off-by: Olivier Lamy olamy@apache.org

See JENKINS-75278.

Testing done

Proposed changelog entries

Upgrade to Jetty 12.0.17 to fix User pages for users with '\' in the user name fail

Proposed changelog category

/label bug

Proposed upgrade guidelines

N/A

Submitter checklist

The Jira issue, if it exists, is well-described.
The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
There is automated testing or an explanation as to why this change has no tests.
New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
For dependency updates, there are links to external changelogs and, if possible, full differentials.
For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

There are at least two (2) approvals for the pull request and no outstanding requests for change.
Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
Proper changelog labels are set so that the changelog can be generated automatically.
If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

github-actions · 2025-03-05T17:54:47Z

Please take a moment and address the merge conflicts of your pull request. Thanks!

olamy · 2025-03-07T09:30:46Z

tests looks very flaky :(

basil

java.lang.AssertionError: expected:<400> but was:<404>
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.failNotEquals(Assert.java:835)
	at org.junit.Assert.assertEquals(Assert.java:647)
	at org.junit.Assert.assertEquals(Assert.java:633)
	at hudson.model.DirectoryBrowserSupportTest.windows_cannotViewAbsolutePath(DirectoryBrowserSupportTest.java:1122)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at org.jvnet.hudson.test.JenkinsRule$1.evaluate(JenkinsRule.java:659)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.lang.Thread.run(Thread.java:840)

stale

test/src/test/java/hudson/model/DirectoryBrowserSupportTest.java

basil

This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback. Please see the merge process documentation for more information about the merge process. Thanks!

A1exKH

LGTM.

…fter upgrading to 2.479.1 Signed-off-by: Olivier Lamy <olamy@apache.org>

Signed-off-by: Olivier Lamy <olamy@apache.org>

…fter upgrading to 2.479.1 (jenkinsci#10344) Signed-off-by: Olivier Lamy <olamy@apache.org> (cherry picked from commit 9f91315)

…fter upgrading to 2.479.1 (jenkinsci#10344) Signed-off-by: Olivier Lamy <olamy@apache.org> (cherry picked from commit 9f91315) Add commons-discovery dependency version 0.5 in pom.xml Remove unnecessary SuppressFBWarnings annotations from CLI.java Add path validation and sanitization in CLI.java Add path traversal warnings to readAuthFromFile and getFileFromArguments methods in CLI.java

…fter upgrading to 2.479.1 (jenkinsci#10344) Signed-off-by: Olivier Lamy <olamy@apache.org> (cherry picked from commit 9f91315)

…fter upgrading to 2.479.1 (jenkinsci#10344) Signed-off-by: Olivier Lamy <olamy@apache.org> (cherry picked from commit 9f91315) (cherry picked from commit d667ea5)

olamy added the work-in-progress The PR is under active development, not ready to the final review label Feb 26, 2025

olamy mentioned this pull request Feb 26, 2025

[JENKINS-75278] Upgrade Jetty 12.0.17 which restore UriCompliance.LEGACY previous behaviour jenkinsci/winstone#426

Merged

6 tasks

olamy force-pushed the JENKINS-75278 branch from 6d81cdc to 49c2d7c Compare February 26, 2025 01:58

olamy mentioned this pull request Feb 26, 2025

[JENKINS-75278] Upgrade Jetty 12.0.17 which restore UriCompliance.LEGACY previous behaviour jenkinsci/jenkins-test-harness#930

Merged

6 tasks

github-actions bot added the unresolved-merge-conflict There is a merge conflict with the target branch. label Mar 5, 2025

olamy force-pushed the JENKINS-75278 branch from 0ece2f8 to 2eebde5 Compare March 6, 2025 02:40

github-actions bot removed the unresolved-merge-conflict There is a merge conflict with the target branch. label Mar 6, 2025

comment-ops-bot bot added the bug For changelog: Minor bug. Will be listed after features label Mar 6, 2025

olamy removed the work-in-progress The PR is under active development, not ready to the final review label Mar 6, 2025

olamy marked this pull request as ready for review March 6, 2025 08:57

rsandell approved these changes Mar 6, 2025

View reviewed changes

BorisYaoA approved these changes Mar 6, 2025

View reviewed changes

basil previously requested changes Mar 7, 2025

View reviewed changes

olamy force-pushed the JENKINS-75278 branch from d1f5db5 to edb4526 Compare March 8, 2025 08:41

basil reviewed Mar 10, 2025

View reviewed changes

test/src/test/java/hudson/model/DirectoryBrowserSupportTest.java Show resolved Hide resolved

basil approved these changes Mar 11, 2025

View reviewed changes

basil self-assigned this Mar 11, 2025

basil added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Mar 11, 2025

A1exKH approved these changes Mar 11, 2025

View reviewed changes

olamy added 8 commits March 12, 2025 09:12

[JENKINS-75278] User pages for users with '\' in the user name fail a…

214a0c5

…fter upgrading to 2.479.1 Signed-off-by: Olivier Lamy <olamy@apache.org>

incremental of jenkins-test-harness

a47a2aa

Signed-off-by: Olivier Lamy <olamy@apache.org>

Last incremental of winstone and jenkins-test-harness

aa74b91

Signed-off-by: Olivier Lamy <olamy@apache.org>

fix unit test

11482e5

Signed-off-by: Olivier Lamy <olamy@apache.org>

Use winstone 8.5

5692af9

Signed-off-by: Olivier Lamy <olamy@apache.org>

use release of jenkins-test-harness

7f593ff

Signed-off-by: Olivier Lamy <olamy@apache.org>

Windows

67118a0

Signed-off-by: Olivier Lamy <olamy@apache.org>

windows

de0842c

Signed-off-by: Olivier Lamy <olamy@apache.org>

olamy added 3 commits March 12, 2025 09:12

404 now

1534af1

Signed-off-by: Olivier Lamy <olamy@apache.org>

restore idea file. what a bad idea to have those in the scm...

800789f

Signed-off-by: Olivier Lamy <olamy@apache.org>

not anymore needed comment

c165d2d

Signed-off-by: Olivier Lamy <olamy@apache.org>

olamy force-pushed the JENKINS-75278 branch from d8201c4 to c165d2d Compare March 11, 2025 23:12

basil merged commit 9f91315 into jenkinsci:master Mar 12, 2025
16 checks passed

MarkEWaite mentioned this pull request Mar 18, 2025

Backporting for Jenkins 2.492.3 release candidate #10412

Closed

6 tasks

daniel-beck mentioned this pull request Apr 14, 2025

Escape values inside JS string jenkinsci/stapler#655

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[JENKINS-75278] User pages for users with '\' in the user name fail after upgrading to 2.479.1#10344

[JENKINS-75278] User pages for users with '\' in the user name fail after upgrading to 2.479.1#10344
basil merged 11 commits intojenkinsci:masterfrom
olamy:JENKINS-75278

olamy commented Feb 26, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Mar 5, 2025

Uh oh!

olamy commented Mar 7, 2025

Uh oh!

basil left a comment

Uh oh!

Uh oh!

basil left a comment

Uh oh!

A1exKH left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

olamy commented Feb 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Testing done

Proposed changelog entries

Proposed changelog category

Proposed upgrade guidelines

Submitter checklist

Desired reviewers

Maintainer checklist

Uh oh!

github-actions bot commented Mar 5, 2025

Uh oh!

olamy commented Mar 7, 2025

Uh oh!

basil left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

basil left a comment

Choose a reason for hiding this comment

Uh oh!

A1exKH left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

olamy commented Feb 26, 2025 •

edited

Loading